get rid of all compiler warnings

[Stephen Siegel]

Get rid of all compiler warnings in the TASS code.
front: Ben
model, dynamic, symbolic, state, verify: Steve
other: Tim

[Stephen Siegel]

Warnings now gone from everywhere except front.
Whoever wants to work on removing warnings from front, please accept this ticket.

[zirkel]

I'm still seeing warnings in model and prove as well. Should I work on removing them? Or was something not committed?

[Stephen Siegel]

What warnings do you see? Make sure you are updated. I'm on 1843 and see no warnings in those modules.

[zirkel]

For example, in SimpleIdealProver:

line 70: Unnecessary @SuppressWarnings("unchecked")
line 71: HashMap is a raw type

Same errors for lines 57 and 58 of IdealCVC3HybridProver and lines 54 and 55 of TheoremProverIF

In Function and AbstractFunction, warnings about dead code.

[zirkel]

The suggested way to get rid of the warnings for the ANTLR generated files (according to antlr.org) is to add an @SuppressWarnings("all") in the Java.stg template inside of antlrworks.jar. It's located at antlrworks/org/antlr/codegen/templates/Java. So far I don't see a way to handle it by modifying our build settings.

[zirkel]

All warnings are gone except for those in files that ANTLR generates. Removing these warnings would require changes to ANTLR, or at least to the ANTLR template files. We're not going to do that at this time.

Our policy will be to not introduce any new warnings in our code.