Opened 16 years ago

Closed 16 years ago

#228 closed defect (fixed)

Error reporting issue when parsing .mmp file.

Reported by: dfix Owned by:
Priority: major Milestone: Release 1.0
Component: examples Version: 1.0
Keywords: parser, .mmp, error report, Cc:

Description

This test generates a syntax error at line 12 while being parsed. Apparently it should terminate here and give an error report, but execution continues and it then gets a null pointer exception when extracting the model.

input double x;

typedef struct Test{
	double a;
	}Test;

void main() {

  Test* p;
  Test* q;
  
  p->a = x;
  *q.a = x;
  
  assert p->a == *q.a;
  
}
java.lang.NullPointerException
	at edu.udel.cis.vsl.tass.front.minimp.ModelBuilder.processAST(ModelBuilder.java:319)
	at edu.udel.cis.vsl.tass.front.minimp.ModelBuilder.buildModel(ModelBuilder.java:314)
	at edu.udel.cis.vsl.tass.front.minimp.ModelExtractor.extract(ModelExtractor.java:30)
	at edu.udel.cis.vsl.tass.front.minimp.ModelExtractor.extractModel(ModelExtractor.java:54)
	at pointers.PointerTest.arrowOperatorTest(PointerTest.java:105)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:73)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:46)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:180)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:41)
	at org.junit.runners.ParentRunner$1.evaluate(ParentRunner.java:173)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:220)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:46)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

edu.udel.cis.vsl.tass.front.minimp.parser.SyntaxError: Syntax error found in file: arrowOperator.mmp, on line: 12:2
Left value expected in assignment.
	at edu.udel.cis.vsl.tass.front.minimp.parser.TreeParser.reportSyntaxError(TreeParser.java:2920)
	at edu.udel.cis.vsl.tass.front.minimp.parser.TreeParser.processAssignExpr(TreeParser.java:1433)
	at edu.udel.cis.vsl.tass.front.minimp.parser.TreeParser.processExpr(TreeParser.java:1421)
	at edu.udel.cis.vsl.tass.front.minimp.parser.TreeParser.processExprStmt(TreeParser.java:2738)
	at edu.udel.cis.vsl.tass.front.minimp.parser.TreeParser.processStatement(TreeParser.java:2211)
	at edu.udel.cis.vsl.tass.front.minimp.parser.TreeParser.processStmtList(TreeParser.java:1405)
	at edu.udel.cis.vsl.tass.front.minimp.parser.TreeParser.processFunctionBody(TreeParser.java:1379)
	at edu.udel.cis.vsl.tass.front.minimp.parser.TreeParser.processFunction(TreeParser.java:1273)
	at edu.udel.cis.vsl.tass.front.minimp.parser.TreeParser.processAST(TreeParser.java:285)
	at edu.udel.cis.vsl.tass.front.minimp.ModelExtractor.extract(ModelExtractor.java:29)
	at edu.udel.cis.vsl.tass.front.minimp.ModelExtractor.extractModel(ModelExtractor.java:54)
	at pointers.PointerTest.arrowOperatorTest(PointerTest.java:105)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:73)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:46)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:180)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:41)
	at org.junit.runners.ParentRunner$1.evaluate(ParentRunner.java:173)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:220)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:46)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

Change History (1)

comment:1 by Stephen Siegel, 16 years ago

Resolution: fixed
Status: newclosed

Fixed by making SyntaxException not RuntimeException and throwing up to top (TASS) and reporting there before exiting with error code -1.

Note: See TracTickets for help on using tickets.