Pointer decl/initialization expression leads to NullPointerException in TreeParser

[Stephen Siegel]

Pointer decl leads to NullPointerException in TreeParser.
Added test in pointers directory called pointerAddition...

input int N {N>=0 && N<=3};
int[N] a;

void main() {
  int i;
  int* p = &a[0];
  
  for (i=0; i<N; i++) {
    *(p+i) = i;
  }
  for (i=0; i<N; i++) {
    assert a[i]==i;
  }
}

Leads to error:

java.lang.NullPointerException
	at edu.udel.cis.vsl.minimp.front.minimp.parser.TreeParser.processExpr(TreeParser.java:691)
	at edu.udel.cis.vsl.minimp.front.minimp.parser.TreeParser.processVarDeclBody(TreeParser.java:374)
	at edu.udel.cis.vsl.minimp.front.minimp.parser.TreeParser.processVariableList(TreeParser.java:665)
	at edu.udel.cis.vsl.minimp.front.minimp.parser.TreeParser.processFunctionBody(TreeParser.java:638)
	at edu.udel.cis.vsl.minimp.front.minimp.parser.TreeParser.processFunction(TreeParser.java:490)
	at edu.udel.cis.vsl.minimp.front.minimp.parser.TreeParser.processAST(TreeParser.java:180)
	at edu.udel.cis.vsl.minimp.front.minimp.ModelExtractor.extract(ModelExtractor.java:29)
	at edu.udel.cis.vsl.minimp.front.minimp.ModelExtractor.extractModel(ModelExtractor.java:54)
	at pointers.PointerTest.pointerAdditionTest(PointerTest.java:70)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:73)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:46)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:180)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:41)
	at org.junit.runners.ParentRunner$1.evaluate(ParentRunner.java:173)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:220)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:46)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

[ywei]

Fixed the bug in TreeParser.java in order to get the correct initialization code. However, I got another exception from model:
Exception in thread "main" edu.udel.cis.vsl.minimp.model.IF.SyntaxException: Syntax error in pointerAddition.mmp 6.11--6.16: "&a[0];":
&a[0]
A variable of non-scalar type cannot be initialized: p

at edu.udel.cis.vsl.minimp.model.impl.variable.Variable.setInitializationExpression(Variable.java:180)
at edu.udel.cis.vsl.minimp.model.impl.Model.setInitializationExpression(Model.java:851)
at edu.udel.cis.vsl.minimp.front.minimp.ModelBuilder.processLocalVariables(ModelBuilder.java:511)
at edu.udel.cis.vsl.minimp.front.minimp.ModelBuilder.processFunctionBody(ModelBuilder.java:487)
at edu.udel.cis.vsl.minimp.front.minimp.ModelBuilder.processFunctions(ModelBuilder.java:459)
at edu.udel.cis.vsl.minimp.front.minimp.ModelBuilder.processAST(ModelBuilder.java:289)
at edu.udel.cis.vsl.minimp.front.minimp.ModelBuilder.buildModel(ModelBuilder.java:283)
at edu.udel.cis.vsl.minimp.front.minimp.ModelExtractor.extract(ModelExtractor.java:30)
at edu.udel.cis.vsl.minimp.front.minimp.ModelExtractor.extractModel(ModelExtractor.java:54)
at edu.udel.cis.vsl.minimp.MiniMP.verify(MiniMP.java:408)
at edu.udel.cis.vsl.minimp.MiniMP.main(MiniMP.java:483)

[ywei]

Tests now pass after the recent fix from model module.