Opened 16 years ago
Closed 16 years ago
#114 closed defect (fixed)
TileTests fail
| Reported by: | Stephen Siegel | Owned by: | Stephen Siegel |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | semantics | Version: | 1.0 |
| Keywords: | Cc: |
Description
All of the compare tests fail for tile tests.
Change History (2)
comment:1 by , 16 years ago
| Component: | test → semantics |
|---|---|
| Owner: | set to |
| Status: | new → accepted |
comment:2 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
Fixed. Problem was in the search for occurrences of symbolic constants with names of the form "X*". Array variables had a toString method that also included the type information so did not match X*. Changed that so that now the toString method always just returns the name of the symbolic constant. Added another method typedString for any value that appends the type in parentheses. Used this method when printing out state.
This also fixed the MatrixMultiplication tests.
Ultimately, a better way should be found to deal with input variable values (instead of relying on strings to identify them.)

Reason is that the symbolic constants are not getting assigned correctly in the initial state of the impl. The impl has an extra input variable B. Its inputs are N,B,A. Both N and A correspond to inputs in the spec, where they are assigned X_0, X_1. So in the impl initial state, N is assigned X_0, B is then assigned X_1 (since this is the first available constant after X_0), then A is assigned X_1 (because that's what it got in the spec.) Need to change so that "first available constant" takes into consideration the names already used in the spec.